add pagination to datasets #2512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Robinson <merobi@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #2512 +/- ##
=========================================
Coverage 83.80% 83.80%
Complexity 1233 1233
=========================================
Files 235 235
Lines 5625 5625
Branches 270 270
=========================================
Hits 4714 4714
Misses 767 767
Partials 144 144 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
phixMe
reviewed
Jun 12, 2023
web/src/routes/datasets/Datasets.tsx
Outdated
| page: 1, | ||
| pageIsLast: false | ||
| } | ||
| this.pageSize = 20 |
There was a problem hiding this comment.
I would declare this as a const outside of the component like
const PAGE_SIZE = 20There was a problem hiding this comment.
@phixMe that fixed the issue. Thank you.
Signed-off-by: Michael Robinson <merobi@gmail.com>
Signed-off-by: Michael Robinson <merobi@gmail.com>
Signed-off-by: Michael Robinson <merobi@gmail.com>
mobuchowski
approved these changes
Jun 13, 2023
mobuchowski
approved these changes
Jun 13, 2023
Signed-off-by: Michael Robinson <merobi@gmail.com>
Xavier-Cliquennois
pushed a commit
to Xavier-Cliquennois/marquez
that referenced
this pull request
Jul 26, 2023
* add pagination to datasets --------- Signed-off-by: Michael Robinson <merobi@gmail.com> Signed-off-by: Xavier-Cliquennois <xavier.cliquennois@wearegraphite.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Pagination would make viewing datasets in namespaces with many datasets more manageable, as in the case of events. But currently datasets are not paginated.
Solution
This paginates the datasets route in the same way events are paginated.
One-line summary: adds pagination to datasets
Checklist
CHANGELOG.md(Depending on the change, this may not be necessary)..sqldatabase schema migration according to Flyway's naming convention (if relevant)